Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_licensemanager_license_configuration: Add arn and owner_account_id attributes #17160

Merged
merged 1 commit into from
Feb 11, 2021
Merged

resource/aws_licensemanager_license_configuration: Add arn and owner_account_id attributes #17160

merged 1 commit into from
Feb 11, 2021

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16978

Release note for CHANGELOG:

* resource/aws_licensemanager_license_configuration: Add arn and owner_account_id attributes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLicenseManagerLicenseConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLicenseManagerLicenseConfiguration_ -timeout 120m
=== RUN   TestAccAWSLicenseManagerLicenseConfiguration_basic
=== PAUSE TestAccAWSLicenseManagerLicenseConfiguration_basic
=== RUN   TestAccAWSLicenseManagerLicenseConfiguration_update
=== PAUSE TestAccAWSLicenseManagerLicenseConfiguration_update
=== CONT  TestAccAWSLicenseManagerLicenseConfiguration_basic
=== CONT  TestAccAWSLicenseManagerLicenseConfiguration_update
--- PASS: TestAccAWSLicenseManagerLicenseConfiguration_basic (41.56s)
--- PASS: TestAccAWSLicenseManagerLicenseConfiguration_update (66.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.796s

Thank you for your review!

@shuheiktgw shuheiktgw requested a review from a team as a code owner January 18, 2021 22:58
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/licensemanager Issues and PRs that pertain to the licensemanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 18, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 18, 2021
@shuheiktgw shuheiktgw mentioned this pull request Jan 18, 2021
Closed
12 tasks
Base automatically changed from master to main January 23, 2021 01:00
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 11, 2021
bflad
bflad approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you, @shuheiktgw 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLicenseManagerLicenseConfiguration_basic (12.77s)
--- PASS: TestAccAWSLicenseManagerLicenseConfiguration_update (22.02s)

bflad added a commit that referenced this pull request Feb 11, 2021
@bflad
Add CHANGELOG entry for #17160
30f2c1e
@bflad bflad merged commit c9fd565 into hashicorp:main Feb 11, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/licensemanager Issues and PRs that pertain to the licensemanager service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shuheiktgw @bflad